Page MenuHomePhabricator

restored --head support
ClosedPublic

Authored by talshiri on Sep 8 2014, 8:52 PM.
Tags
None
Referenced Files
F18059716: D10447.id25124.diff
Mon, Aug 4, 11:18 AM
F18047990: D10447.diff
Sun, Aug 3, 1:17 PM
F18035627: D10447.id25123.diff
Sun, Aug 3, 1:36 AM
F17944218: D10447.id.diff
Thu, Jul 31, 9:42 AM
F17927646: D10447.diff
Wed, Jul 30, 2:57 PM
Unknown Object (File)
Jul 3 2025, 10:51 AM
Unknown Object (File)
Jun 29 2025, 12:06 AM
Unknown Object (File)
Jun 28 2025, 5:03 PM
Subscribers

Details

Summary

the call to setHeadCommit() was accidentally placed in a if ($background) {} block, which was removed in 54bea94. This adds the removed call.

Test Plan

used --head, worked as expected

Diff Detail

Repository
rARC Arcanist
Branch
fixed_head_arg
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2469
Build 2473: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

talshiri retitled this revision from to restored --head support.
talshiri updated this object.
talshiri edited the test plan for this revision. (Show Details)
talshiri added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 8 2014, 9:02 PM
epriestley updated this revision to Diff 25124.

Closed by commit rARCec35375e96ad (authored by @talshiri, committed by @epriestley).