Add a setting for selecting SMTP mail encoding
ClosedPublic
Actions

Authored by epriestley on Aug 30 2014, 2:48 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T5956: Email has extraneous = in Exchange/Outlook

Commits

Restricted Diffusion Commit
rP957c1d6602a5: Add a setting for selecting SMTP mail encoding

Summary

Fixes T5956. We changed the default mail encoding to quoted-printable to fix delivery via SendGrid via SMTP, but this broke multiple other mailers.

Change the default back to 8bit (which works everywhere except SendGrid).
Add a configuration setting for selecting quoted-printable.
Document this issue.
Discourage use of SendGrid in documentation.

@klimek @nickz This reverts the quoted-printable fix for SendGrid. You will need to adjust your configurations (set phpmailer.smtp-encoding to quoted-printable) and restart your daemons or mail will get double newlines again.

Test Plan

Sent mail via SendGrid with various phpmailer.smtp-encoding settings, saw mail arrive with specified encoding.

Diff Detail

Repository

rP Phabricator

Branch

qprint

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2403
Build 2407: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25019.Aug 30 2014, 2:48 PM

epriestley retitled this revision from to Add a setting for selecting SMTP mail encoding.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5956: Email has extraneous = in Exchange/Outlook.

epriestley added subscribers: nickz, klimek.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 30 2014, 2:48 PM

Harbormaster completed remote builds in B2403: Diff 25019.Aug 30 2014, 2:49 PM

I feel a little bad about the note of discouragement re: SendGrid, but 'tis a fair note.

This revision is now accepted and ready to land.Aug 30 2014, 3:16 PM

There are a host of issues driving the SendGrid thing:

T5956 / the quoted-printable stuff;
T3435 (it took them like 3 years to add web API support for "CC", at least sort of);
T4199 (various unreproducible mangling and generation of HTML bodies);
they disabled my "free" test account or a $0.39 nonpayment which I believe was billed incorrectly -- I'm at least partially at fault here since I legitimately didn't pay the $0.39 I owed, but still;
their web interface is slow and hard to use / find things in;
access to the inbound "Parse API" is not available for the $10/month plan (the first plan it's available for is $80/month) except that it's available with the "free" plan, sort of, except there are two "free" plans?
they apparently manually allocate new accounts, which takes a nontrivial amount of time.

None of this stuff is a big deal, and SendGrid is basically a fine service, but MailGun and SES haven't had any of these issues: MailGun and SES just work, while SendGrid has consistently hit issues which require our involvement to resolve, and whenever I need to resolve SendGrid stuff it takes more time and effort than it does with other services.