Page MenuHomePhabricator

Email has extraneous = in Exchange/Outlook
Closed, ResolvedPublic

Description

After updating today (previous update was around 11 August), mail notifications have started adding extraneous equals (=) symbols when viewed in Outlook/Exchange.
It is working correctly through Gmail however.

I'm not sure if this is related to T5861 or the addition of HTML emails (D9375).

Email is coming through as follows:

uqmreill accepted this commit.

USERS
  uqccolbo (Author)

COMMIT=

  https://phabricator.app.uq.edu.au:8080/rNAVAeffa4acf6ed1

To: uqcc=
olbo, uqrrerri, uqjskinn, uqjlond3

Note the extraneous equals after COMMIT and the break in To:

The message source of a similar email in Gmail is as follows:

Subject: [Diffusion] [Accepted] rNAVA6ed9daaabb79: Change parent location meta to Located Near
Message-ID: <695dcaef3351a234586210d4e3e9380a@localhost.localdomain>
X-Priority: 3
Thread-Topic: Commit rNAVA6ed9daaabb79142674f67f1e44b0d3ef4336b6fb
X-Phabricator-To: <PHID-USER-blrudgbm7bcvymu32jrw>
X-Phabricator-To: <PHID-USER-jnz7iyezusv7fjnyzxoo>
X-Phabricator-To: <PHID-USER-gl4g2evgxoamuiqaw67m>
X-Phabricator-To: <PHID-USER-55s5w65gdtk4qvuoucfz>
In-Reply-To: <diffusion-audit-PHID-CMIT-hgim2j25t342cpv2idk6@phabricator.example.com>
References: <diffusion-audit-PHID-CMIT-hgim2j25t342cpv2idk6@phabricator.example.com>
Thread-Index: Yzk3MWI5OTNiZGYwZjg5NzBmMWQxMWU3MGEwIFP6x2E=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
X-UQ-FilterTime: 1408943970
X-Scanned-By: MIMEDefang 2.73 on UQ Mailhub

uqmreill accepted this commit.=0A=0AUSERS=0A  uqccolbo (Author)=0A=0ACOMMIT=
=0A  https://phabricator.app.uq.edu.au:8080/rNAVA6ed9daaabb79=0A=0ATo: uqcc=
olbo, uqrrerri, uqjskinn, uqjlond3=0A

It looks like it's related to the line length.

Thanks.

Event Timeline

zorfling assigned this task to epriestley.
zorfling raised the priority of this task from to Needs Triage.
zorfling updated the task description. (Show Details)
zorfling added a project: Phabricator.
zorfling added a subscriber: zorfling.

Which mail adapter are you using (SendGrid, SES, Mailgun, etc)?

This is probably related to rPb7ad48a / rP5449200.

Yep, rPb7ad48a is probably it, we're using PHPMailerLite

Does reverting that fix it? SendGrid's MTAs have a similar issue (all newlines are doubled) without that patch, so if reverting fixes things we might need to do some kind of really silly "if the server is X, use this encoding; if the server is Y, use this encoding" thing.

Yep, reverting rPb7ad48a gets everything back to normal.
Sorry! ;)

@aik099, are you using one of PHPMailer or PHPMailerLite? If so, does reverting rPb7ad48aa (PHPMailerLite) or rP54492009 (PHPMailer) resolve the issue for you?

are you using one of PHPMailer or PHPMailerLite?

I'm using PHPMailerLite I think, because the metamta.mail-adapter setting says PhabricatorMailImplementationPHPMailerLiteAdapter and it doesn't have Customized mark on it.

If so, does reverting rPb7ad48aa (PHPMailerLite) or rP54492009 (PHPMailer) resolve the issue for you?

These are fixed you made right now. Should I update to see if it helped?

Oh, do you not have those changes yet? Those changes were made a while ago and are the only recent changes we made here, so I suspect one of them is what introduced the bug.

I do. I've reverted https://secure.phabricator.com/rPb7ad48aa50f4634caa38f95c3cefb20839be6fcf as you suggested and it got worse:

Phabricator_PhpMailerLiteWithoutQuotedPrintable.png (222×482 px, 28 KB)

And the View Source is:

volodimir added inline comments.=0A=0AINLINE COMMENTS=0A  /projects/asico/t=

runk/modules/custom/units/sections/in-commerce/products/e_product_eh.php:85=

 =D0=9D=D0=B5 =D1=83=D0=B2=D0=B5=D1=80=D0=B5=D0=BD, =D1=87=D1=82=D0=BE =D0=

=BE=D0=BD=D0=BE =D1=83 =D0=BC=D0=B5=D0=BD=D1=8F =D0=B2=D0=BA=D0=BB=D1=8E=D1=

=87=D0=B5=D0=BD=D0=BE. =D0=A1=D0=B5=D0=B9=D1=87=D0=B0=D1=81 =D0=BF=D0=BE=D1=

=81=D0=BC=D0=BE=D1=82=D1=80=D1=8E.=0A=0AUSERS=0A  volodimir (Author)=0A=0AC=

OMMIT=0A  http://qa.intechnic.com/rASI14278=0A=0AREPLY HANDLER ACTIONS=0A  =

Reply to comment.=0A=0ATo: volodimir, alex=0ACc: alex=0A

in fact it looks like removing quoted printable encoding had no effect at all.

Maybe it's the quoted printable encoding is done wrong. I guess for PhpMailerLite the quoted printable encoding maybe is default value.

Sorry, here's a more detailed explanation:

  • The default value is "8bit".
  • The commits referenced above changed the setting to "quoted-printable", to fix SendGrid. They were made about a week ago.
  • My theory is that "quoted-printable" does not work for you, and we need to go back to "8bit". For example, "quoted-printable" seems to have broken mail for @zorfling, earlier on this ticket.
  • If you are running a version of Phabricator more recent than rPb7ad48 (Aug 20), and reverting that change (e.g., commenting out the "quoted-printable" line, so we go back to "8bit"), that will confirm that you are also affected by this issue.
  • If you are running a version of Phabricator older than rPb7ad48, I'm wrong about the root cause of your issue and merged this incorrectly.

Oh, sorry, I missed https://secure.phabricator.com/T5956#17. Did you restart the daemons after making the change?

Nope, should I? It's the ./bin/phd restart?

Yes, the daemons won't reflect configuration changes until they're restarted.

That did help indeed.

The View Source is:

volodimir added inline comments.

INLINE COMMENTS
  /projects/asico/trunk/modules/custom/units/sections/in-commerce/products/e_product_eh.php:85 Не уверен, что оно у меня включено. Сейчас посмотрю.

USERS
  volodimir (Author)

COMMIT
  http://qa.intechnic.com/rASI14278

REPLY HANDLER ACTIONS
  Reply to comment.

To: volodimir, alex
Cc: alex

So the bug seems to be in how the PHPMailerLite does quoted printable encodings.