Page MenuHomePhabricator
Differential D10352

Allow lines to be specified as comma delimited number ranges for arc browse
ClosedPublic
Actions

Authored by vm on Aug 26 2014, 3:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 10:47 AM
Unknown Object (File)
Mar 5 2024, 3:31 AM
Unknown Object (File)
Mar 4 2024, 4:53 PM
Unknown Object (File)
Mar 1 2024, 11:09 AM
Unknown Object (File)
Mar 1 2024, 11:03 AM
Unknown Object (File)
Feb 26 2024, 6:09 AM
Unknown Object (File)
Feb 11 2024, 5:53 PM
Unknown Object (File)
Feb 10 2024, 11:40 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Like" token, awarded by avivey.

Details

Reviewers
epriestley
btrahan
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5971: Allow multiline selection via `arc browse`
Commits
rARCf21262048fcd: Allow lines to be specified as comma delimited number ranges for arc browse
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Ref T5971. We lose validation of the line ranges, but I don't think that's a huge issue.

Test Plan

Ran arc browse README, arc browse README:3, and arc browse README:3,6-7

Diff Detail

Repository
rARC Arcanist
Branch
browse
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2348
Build 2352: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

vm updated this revision to Diff 24919.Aug 26 2014, 3:17 PM
vm retitled this revision from to Allow lines to be specified as comma delimited number ranges for arc browse.
vm updated this object.
vm edited the test plan for this revision. (Show Details)
vm added reviewers: epriestley, btrahan.
vm added a task: T5971: Allow multiline selection via `arc browse`.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 26 2014, 3:17 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2348: Diff 24919.Aug 26 2014, 3:18 PM
epriestley accepted this revision.Aug 26 2014, 4:02 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 26 2014, 4:02 PM
epriestley closed this revision.Aug 26 2014, 4:02 PM
epriestley updated this revision to Diff 24920.

Closed by commit rARCf21262048fcd (authored by @vm, committed by @epriestley).

avivey awarded a token.Aug 26 2014, 4:34 PM

Revision Contents
Changeset List

PathSize
src/
workflow/
8 lines

Diff 24919

View Options

src/workflow/ArcanistBrowseWorkflow.php

Loading...
Phabricator · Built by Phacility