Page MenuHomePhabricator

Allow multiline selection via `arc browse`
Closed, ResolvedPublic

Description

In uber/sublime-phabricator, we were previously leveraging a hack to open files inside of Phabricator with multiple lines selected. We would add on the line numbers as part of the filename:

# Open README with lines 4-6 selected
# https://secure.phabricator.com/diffusion/ARC/browse/master/README$4-6
arc browse README$4-6

Due to recent changes, that hack has ceased working and been replaced with proper code. A recent pull request has come to fix this but it seems we have lost the multiline highlighting.

https://github.com/uber/sublime-phabricator/pull/7

arc browse README:3-5

Expected behavior: Opens https://secure.phabricator.com/diffusion/ARC/browse/master/README$3-5

Actual behavior: Opens https://secure.phabricator.com/diffusion/ARC/browse/master/README$3

The relevant lines of code can be found here:

https://secure.phabricator.com/diffusion/ARC/browse/master/src/workflow/ArcanistBrowseWorkflow.php;e336b04aa10bde5cc0e3a609a4ca4fa4551e2c4e$147-178

Link to uber/sublime-phabricator: https://github.com/uber/sublime-phabricator

Event Timeline

twolfson raised the priority of this task from to Needs Triage.
twolfson updated the task description. (Show Details)
twolfson added a project: Arcanist.
twolfson added a subscriber: twolfson.
vm added a subscriber: vm.Aug 26 2014, 3:02 PM
epriestley closed this task as Resolved.Aug 26 2014, 4:03 PM
epriestley claimed this task.

D10352 should resolve this.