Page MenuHomePhabricator

Write a "resign" audit relationship even if actor has no relationship
ClosedPublic

Authored by epriestley on Aug 4 2014, 3:57 PM.
Tags
None
Referenced Files
F18392712: D10137.id.diff
Fri, Aug 29, 8:30 AM
F18383316: D10137.diff
Thu, Aug 28, 10:53 PM
F18047809: D10137.id.diff
Sun, Aug 3, 1:09 PM
F17923978: D10137.id24384.diff
Wed, Jul 30, 9:04 AM
F17923214: D10137.id24400.diff
Jul 30 2025, 7:54 AM
F17902230: D10137.id.diff
Jul 29 2025, 10:10 AM
F17884247: D10137.diff
Jul 28 2025, 11:53 PM
Unknown Object (File)
Jun 28 2025, 3:58 PM
Subscribers

Details

Summary

Ref T4896. I got this logic slightly wrong when porting it over: we always want to write this relationship, to allow members of a project with an audit request against a commit to resign and get it out of their queue.

Test Plan
  • Resigned from a commit with an existing relationship.
  • Resigned from a commit with no existing relationship, saw one added.

Diff Detail

Repository
rP Phabricator
Branch
audit1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2027
Build 2028: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Write a "resign" audit relationship even if actor has no relationship.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
mbishopim3 edited edge metadata.

Confirmed working now.

This revision is now accepted and ready to land.Aug 4 2014, 5:00 PM
epriestley updated this revision to Diff 24400.

Closed by commit rP725e2fa41055 (authored by @epriestley).