Page MenuHomePhabricator

Write a "resign" audit relationship even if actor has no relationship
ClosedPublic

Authored by epriestley on Aug 4 2014, 3:57 PM.
Tags
None
Referenced Files
F13049259: D10137.id24400.diff
Fri, Apr 19, 2:06 AM
F13049258: D10137.id24384.diff
Fri, Apr 19, 2:06 AM
F13049257: D10137.id.diff
Fri, Apr 19, 2:06 AM
Unknown Object (File)
Thu, Apr 11, 11:21 PM
Unknown Object (File)
Thu, Apr 11, 3:28 AM
Unknown Object (File)
Fri, Mar 29, 9:26 PM
Unknown Object (File)
Fri, Mar 29, 9:34 AM
Unknown Object (File)
Thu, Mar 28, 6:53 PM
Subscribers

Details

Summary

Ref T4896. I got this logic slightly wrong when porting it over: we always want to write this relationship, to allow members of a project with an audit request against a commit to resign and get it out of their queue.

Test Plan
  • Resigned from a commit with an existing relationship.
  • Resigned from a commit with no existing relationship, saw one added.

Diff Detail

Repository
rP Phabricator
Branch
audit1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2027
Build 2028: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Write a "resign" audit relationship even if actor has no relationship.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
mbishopim3 edited edge metadata.

Confirmed working now.

This revision is now accepted and ready to land.Aug 4 2014, 5:00 PM
epriestley updated this revision to Diff 24400.

Closed by commit rP725e2fa41055 (authored by @epriestley).