Paths

Table of Contentst

Omit unnecessary function call
ClosedPublic
Actions

Authored by joshuaspence on Jul 25 2014, 6:01 AM.

Tags

None

Referenced Files

	F14004277: D10050.diff
	Sat, Oct 26, 5:47 PM

	F13999856: D10050.id.diff
	Thu, Oct 24, 5:35 PM

	F13998650: D10050.diff
	Thu, Oct 24, 10:28 AM

	F13995838: D10050.id24168.diff
	Wed, Oct 23, 3:59 PM

	F13980376: D10050.id24170.diff
	Sat, Oct 19, 10:16 AM

	Unknown Object (File)
	Oct 8 2024, 1:33 AM

	Unknown Object (File)
	Sep 20 2024, 3:24 PM

	Unknown Object (File)
	Sep 2 2024, 10:53 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP1450c0e8d6ad: Omit unnecessary function call

Summary

As mentioned on rP8ce35e6b67e7e2a81b274bab7a6dd19dedb4df06, setConcreteOnly(true) can be omitted since (lacking magical powers) loadObjects() will always only instantiate concrete objects.

Test Plan

N/A

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1895
Build 1896: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 24168.Jul 25 2014, 6:01 AM

joshuaspence retitled this revision from to Omit unnecessary function call.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 25 2014, 6:01 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1895: Diff 24168.Jul 25 2014, 6:02 AM

epriestley accepted this revision.Jul 25 2014, 1:00 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 25 2014, 1:00 PM

Closed by commit rP1450c0e8d6ad (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

method/

ConduitQueryConduitAPIMethod.php

1 line

Diff 24168

View Options

src/applications/conduit/method/ConduitQueryConduitAPIMethod.php

Omit unnecessary function callClosedPublicActions