HomePhabricator

Fix an issue with `ConduitQueryConduitAPIMethod`

Description

Fix an issue with ConduitQueryConduitAPIMethod

Fixes an issue with D9991. A user was hitting the following exception:

echo '{}' | arc --conduit-uri='http://phabricator.joshuaspence.com'
call-conduit conduit.query
Waiting for JSON parameters on stdin...
Exception
[HTTP/500] Internal Server Error
>>> UNRECOVERABLE FATAL ERROR <<<

Call to a member function getAPIMethodName() on a non-object

/usr/src/phabricator/src/applications/conduit/method/ConduitQueryConduitAPIMethod.php:34

┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻
(Run with --trace for a full exception trace.)

Auditors: epriestley

Details

Auditors
epriestley
Group Auditors
Cowboy Commits
Provenance
joshuaspenceAuthored on
joshuaspencePushed on Jul 25 2014, 5:54 AM
Parents
rPda49ae8fe2f3: Bump remarkup engine version for new list stuff
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley added inline comments.
/src/applications/conduit/method/ConduitQueryConduitAPIMethod.php
29

You can omit this with loadObjects(), since (lacking magical powers) it will always only instantiate concrete objects.