Paths

Table of Contentst

Omit unnecessary function call
ClosedPublic
Actions

Authored by joshuaspence on Jul 25 2014, 6:01 AM.

Tags

None

Referenced Files

	F14360275: D10050.diff
	Fri, Dec 20, 10:08 AM

	Unknown Object (File)
	Thu, Dec 5, 8:15 AM

	Unknown Object (File)
	Mon, Dec 2, 3:45 PM

	Unknown Object (File)
	Mon, Nov 25, 9:06 AM

	Unknown Object (File)
	Thu, Nov 21, 1:53 PM

	Unknown Object (File)
	Nov 16 2024, 7:39 PM

	Unknown Object (File)
	Nov 11 2024, 4:50 AM

	Unknown Object (File)
	Nov 11 2024, 4:50 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP1450c0e8d6ad: Omit unnecessary function call

Summary

As mentioned on rP8ce35e6b67e7e2a81b274bab7a6dd19dedb4df06, setConcreteOnly(true) can be omitted since (lacking magical powers) loadObjects() will always only instantiate concrete objects.

Test Plan

N/A

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 24168.Jul 25 2014, 6:01 AM

joshuaspence retitled this revision from to Omit unnecessary function call.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 25 2014, 6:01 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1895: Diff 24168.Jul 25 2014, 6:02 AM

epriestley accepted this revision.Jul 25 2014, 1:00 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 25 2014, 1:00 PM

Closed by commit rP1450c0e8d6ad (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

method/

ConduitQueryConduitAPIMethod.php

1 line

Diff 24170

View Options

src/applications/conduit/method/ConduitQueryConduitAPIMethod.php

Omit unnecessary function callClosedPublicActions