Paths

Table of Contentst

Differential D10039

Simplify the implementation of `PhabricatorPolicyCapability` subclasses
ClosedPublic
Actions

Authored by joshuaspence on Jul 24 2014, 12:42 PM.

Tags

None

Referenced Files

	F18389797: D10039.id24127.diff
	Fri, Aug 29, 6:10 AM

	F18387726: D10039.id24127.diff
	Fri, Aug 29, 3:39 AM

	F18387314: D10039.diff
	Fri, Aug 29, 3:10 AM

	F18387281: D10039.diff
	Fri, Aug 29, 3:08 AM

	F18383430: D10039.diff
	Thu, Aug 28, 11:01 PM

	F18379489: D10039.id.diff
	Thu, Aug 28, 4:03 PM

	F18361726: D10039.diff
	Wed, Aug 27, 12:35 PM

	F17955892: D10039.id24136.diff
	Fri, Aug 1, 5:07 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPb4d7a9de3912: Simplify the implementation of `PhabricatorPolicyCapability` subclasses

Summary

Instead of implementing the getCapabilityKey method in all subclasses of PhabricatorPolicyCapability, provide a final implementation in the base class which uses reflection. See D9837 and D9985 for similar implementations.

Test Plan

N/A

Diff Detail

Repository

Branch

policy

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 1875
Build 1876: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	0 ms	testAllQueriesBelongToActualApplications
	0 ms	testAdminPolicy
	0 ms	testCustomPolicyRuleAdministrators
	0 ms	testCustomPolicyRuleLunarPhase
	0 ms	testCustomPolicyRuleUser
		View Full Test Results (1 Failed · 18 Passed)

Event Timeline

joshuaspence updated this revision to Diff 24127.Jul 24 2014, 12:42 PM

joshuaspence retitled this revision from to Simplify the implementation of `PhabricatorPolicyCapability` subclasses.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 24 2014, 12:42 PM

Herald added subscribers: hach-que, Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1875: Diff 24127.Jul 24 2014, 12:43 PM

epriestley accepted this revision.Jul 24 2014, 1:26 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 24 2014, 1:26 PM

Closed by commit rPb4d7a9de3912 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

applications/

countdown/

capability/

PhabricatorCountdownDefaultViewCapability.php

4 lines

differential/

capability/

DifferentialDefaultViewCapability.php

4 lines

diffusion/

capability/

DiffusionCreateRepositoriesCapability.php

4 lines

DiffusionDefaultEditCapability.php

4 lines

DiffusionDefaultPushCapability.php

4 lines

DiffusionDefaultViewCapability.php

4 lines

DiffusionPushCapability.php

4 lines

drydock/

capability/

DrydockCreateBlueprintsCapability.php

4 lines

DrydockDefaultEditCapability.php

4 lines

DrydockDefaultViewCapability.php

4 lines

harbormaster/

capability/

HarbormasterManagePlansCapability.php

4 lines

herald/

capability/

HeraldManageGlobalRulesCapability.php

4 lines

legalpad/

capability/

LegalpadCreateDocumentsCapability.php

4 lines

LegalpadDefaultEditCapability.php

4 lines

LegalpadDefaultViewCapability.php

4 lines

macro/

capability/

PhabricatorMacroManageCapability.php

4 lines

maniphest/

capability/

ManiphestBulkEditCapability.php

4 lines

ManiphestDefaultEditCapability.php

4 lines

ManiphestDefaultViewCapability.php

4 lines

ManiphestEditAssignCapability.php

4 lines

ManiphestEditPoliciesCapability.php

4 lines

ManiphestEditPriorityCapability.php

4 lines

ManiphestEditProjectsCapability.php

4 lines

ManiphestEditStatusCapability.php

4 lines

nuance/

capability/

NuanceSourceDefaultEditCapability.php

4 lines

NuanceSourceDefaultViewCapability.php

4 lines

NuanceSourceManageCapability.php

4 lines

oauthserver/

capability/

PhabricatorOAuthServerCreateClientsCapability.php

4 lines

paste/

capability/

PasteDefaultViewCapability.php

4 lines

people/

capability/

PeopleBrowseUserDirectoryCapability.php

4 lines

pholio/

capability/

PholioDefaultEditCapability.php

4 lines

PholioDefaultViewCapability.php

4 lines

phragment/

capability/

PhragmentCanCreateCapability.php

4 lines

policy/

capability/

PhabricatorPolicyCanEditCapability.php

4 lines

PhabricatorPolicyCanJoinCapability.php

4 lines

PhabricatorPolicyCanViewCapability.php

4 lines

PhabricatorPolicyCapability.php

22 lines

project/

capability/

ProjectCreateProjectsCapability.php

4 lines

slowvote/

capability/

PhabricatorSlowvoteDefaultViewCapability.php

4 lines

Diff 24127

src/applications/countdown/capability/PhabricatorCountdownDefaultViewCapability.php

Loading...

src/applications/differential/capability/DifferentialDefaultViewCapability.php

Loading...

src/applications/diffusion/capability/DiffusionCreateRepositoriesCapability.php

Loading...

src/applications/diffusion/capability/DiffusionDefaultEditCapability.php

Loading...

src/applications/diffusion/capability/DiffusionDefaultPushCapability.php

Loading...

src/applications/diffusion/capability/DiffusionDefaultViewCapability.php

Loading...

src/applications/diffusion/capability/DiffusionPushCapability.php

Loading...

src/applications/drydock/capability/DrydockCreateBlueprintsCapability.php

Loading...

src/applications/drydock/capability/DrydockDefaultEditCapability.php

Loading...

src/applications/drydock/capability/DrydockDefaultViewCapability.php

Loading...

src/applications/harbormaster/capability/HarbormasterManagePlansCapability.php

Loading...

src/applications/herald/capability/HeraldManageGlobalRulesCapability.php

Loading...

src/applications/legalpad/capability/LegalpadCreateDocumentsCapability.php

Loading...

src/applications/legalpad/capability/LegalpadDefaultEditCapability.php

Loading...

src/applications/legalpad/capability/LegalpadDefaultViewCapability.php

Loading...

src/applications/macro/capability/PhabricatorMacroManageCapability.php

Loading...

src/applications/maniphest/capability/ManiphestBulkEditCapability.php

Loading...

src/applications/maniphest/capability/ManiphestDefaultEditCapability.php

Loading...

src/applications/maniphest/capability/ManiphestDefaultViewCapability.php

Loading...

src/applications/maniphest/capability/ManiphestEditAssignCapability.php

Loading...

src/applications/maniphest/capability/ManiphestEditPoliciesCapability.php

Loading...

src/applications/maniphest/capability/ManiphestEditPriorityCapability.php

Loading...

src/applications/maniphest/capability/ManiphestEditProjectsCapability.php

Loading...

src/applications/maniphest/capability/ManiphestEditStatusCapability.php

Loading...

src/applications/nuance/capability/NuanceSourceDefaultEditCapability.php

Loading...

src/applications/nuance/capability/NuanceSourceDefaultViewCapability.php

Loading...

src/applications/nuance/capability/NuanceSourceManageCapability.php

Loading...

src/applications/oauthserver/capability/PhabricatorOAuthServerCreateClientsCapability.php

Loading...

src/applications/paste/capability/PasteDefaultViewCapability.php

Loading...

src/applications/people/capability/PeopleBrowseUserDirectoryCapability.php

Loading...

src/applications/pholio/capability/PholioDefaultEditCapability.php

Loading...

src/applications/pholio/capability/PholioDefaultViewCapability.php

Loading...

src/applications/phragment/capability/PhragmentCanCreateCapability.php

Loading...

src/applications/policy/capability/PhabricatorPolicyCanEditCapability.php

Loading...

src/applications/policy/capability/PhabricatorPolicyCanJoinCapability.php

Loading...

src/applications/policy/capability/PhabricatorPolicyCanViewCapability.php

Loading...

src/applications/policy/capability/PhabricatorPolicyCapability.php

Loading...

src/applications/project/capability/ProjectCreateProjectsCapability.php

Loading...

src/applications/slowvote/capability/PhabricatorSlowvoteDefaultViewCapability.php

Loading...