Differential D9985 Authored by joshuaspence on Jul 19 2014, 6:35 AM.
Tags None Referenced Files
Subscribers
Details
Summary Instead of implementing the getTypeConstant method in all subclasses of PhabricatorPHIDType, provide a final implementation in the base class which uses reflection. See D9837 for a similar implementation. Test Plan Ran arc unit.
Diff Detail
Event Timelinejoshuaspence retitled this revision from to Simplify the implementation of `PhabricatorPHIDType` subclasses. joshuaspence updated this object. Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 19 2014, 6:35 AM2014-07-19 06:35:26 (UTC+0) Harbormaster completed remote builds in B1782: Diff 23994.Jul 19 2014, 6:36 AM2014-07-19 06:36:34 (UTC+0) Harbormaster completed remote builds in B1783: Diff 23995.Jul 19 2014, 8:41 AM2014-07-19 08:41:51 (UTC+0) epriestley edited edge metadata. This revision is now accepted and ready to land.Jul 21 2014, 2:03 PM2014-07-21 14:03:40 (UTC+0)
Revision Contents
|