Page MenuHomePhabricator

Simplify the implementation of `PhabricatorPolicyCapability` subclasses
ClosedPublic

Authored by joshuaspence on Jul 24 2014, 12:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 5:53 PM
Unknown Object (File)
Sat, Jan 25, 9:12 AM
Unknown Object (File)
Sat, Jan 25, 7:08 AM
Unknown Object (File)
Sat, Jan 11, 7:09 PM
Unknown Object (File)
Jan 3 2025, 1:31 AM
Unknown Object (File)
Dec 8 2024, 7:08 AM
Unknown Object (File)
Dec 4 2024, 11:17 AM
Unknown Object (File)
Nov 1 2024, 7:27 PM

Details

Summary

Instead of implementing the getCapabilityKey method in all subclasses of PhabricatorPolicyCapability, provide a final implementation in the base class which uses reflection. See D9837 and D9985 for similar implementations.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Simplify the implementation of `PhabricatorPolicyCapability` subclasses.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 24 2014, 1:26 PM