Fix some transaction issues when retitling projects
ClosedPublic
Actions

Authored by epriestley on Jul 5 2014, 5:00 PM.

Tags

None

Referenced Files

	F19074752: D9829.id.diff
	Dec 1 2025, 6:44 AM

	F19071527: D9829.diff
	Nov 30 2025, 7:57 PM

	F18997884: D9829.id23589.diff
	Nov 20 2025, 4:27 PM

	F18997883: D9829.id23706.diff
	Nov 20 2025, 4:27 PM

	F18849909: D9829.id23589.diff
	Oct 30 2025, 1:05 PM

	F18844677: D9829.id.diff
	Oct 29 2025, 7:06 AM

	F18843984: D9829.id.diff
	Oct 29 2025, 2:24 AM

	F18842774: D9829.diff
	Oct 28 2025, 6:23 PM

View All Files

Subscribers

epriestley

Tokens

"Doubloon" token, awarded by btrahan."Haypence" token, awarded by joshuaspence.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5458: Renaming a project by changing casing triggers AphrontQueryDuplicateKeyException exception
T5530: MySQL error when renaming project

Commits

Restricted Diffusion Commit
rP3d804bf14d5d: Fix some transaction issues when retitling projects

Summary

Fixes T5530.

We currently fail if you rename a project so it has the same slug (e.g., "Example" -> "ExAmPlE").
We currently fail if you rename a project so one of its secondary hashtags becomes the primary hashtag.

Instead, succeed in these cases.

Test Plan

Successfully performed the renames described above.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23589.Jul 5 2014, 5:00 PM

epriestley retitled this revision from to Fix some transaction issues when retitling projects.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T5530: MySQL error when renaming project.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 5 2014, 5:00 PM

Harbormaster completed remote builds in B1530: Diff 23589.Jul 5 2014, 5:01 PM

joshuaspence awarded a token.Jul 5 2014, 6:50 PM

chad accepted this revision.Jul 5 2014, 6:51 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 5 2014, 6:51 PM

Closed by commit rP3d804bf14d5d (authored by @epriestley).

btrahan awarded a token.Jul 10 2014, 5:34 PM

Krinkle mentioned this in T6909: Unable to rename project and add former primary hashtag as additional hashtag.Jan 8 2015, 8:20 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

editor/

PhabricatorProjectTransactionEditor.php

47 lines

Diff 23706

View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Fix some transaction issues when retitling projectsClosedPublicActions