Page MenuHomePhabricator

Remove `@group` annotations
ClosedPublic

Authored by joshuaspence on Jul 9 2014, 8:51 PM.
Tags
None
Referenced Files
F13241429: D9859.id23657.diff
Wed, May 22, 8:55 PM
F13220058: D9859.largetrue.diff
Sat, May 18, 11:02 PM
F13212985: D9859.diff
Fri, May 17, 7:15 AM
F13198813: D9859.id.diff
Mon, May 13, 10:05 AM
F13193858: D9859.largetrue.diff
Sun, May 12, 6:39 PM
F13190749: D9859.id23677.largetrue.diff
Sat, May 11, 1:18 PM
F13190748: D9859.id23657.largetrue.diff
Sat, May 11, 1:18 PM
F13190747: D9859.id23678.largetrue.diff
Sat, May 11, 1:18 PM

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP8756d82cf6c1: Remove `@group` annotations
Summary

I'm pretty sure that @group annotations are useless now... see D9855. Also fixed various other minor issues.

Test Plan

Eye-ball it.

Diff Detail

Repository
rP Phabricator
Branch
rm_group
Lint
Lint Warnings
Unit
Tests Passed
Build Status
Buildable 1598
Build 1599: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Remove `@group` annotations.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2014, 9:48 PM
joshuaspence edited edge metadata.
  • Found two more... maybe these functions need to be moved? (I don't really know)
joshuaspence updated this revision to Diff 23678.

Closed by commit rP8756d82cf6c1 (authored by @joshuaspence).