Page MenuHomePhabricator

Remove `@group` annotations
ClosedPublic

Authored by joshuaspence on Jul 9 2014, 8:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 6:11 PM
Unknown Object (File)
Wed, Nov 20, 5:01 PM
Unknown Object (File)
Mon, Nov 18, 2:10 AM
Unknown Object (File)
Wed, Nov 13, 7:15 PM
Unknown Object (File)
Mon, Nov 11, 3:00 AM
Unknown Object (File)
Sun, Nov 10, 1:09 AM
Unknown Object (File)
Wed, Nov 6, 11:13 AM
Unknown Object (File)
Tue, Nov 5, 8:54 AM

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP8756d82cf6c1: Remove `@group` annotations
Summary

I'm pretty sure that @group annotations are useless now... see D9855. Also fixed various other minor issues.

Test Plan

Eye-ball it.

Diff Detail

Repository
rP Phabricator
Branch
rm_group
Lint
Lint Warnings
Unit
Tests Passed
Build Status
Buildable 1585
Build 1586: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Remove `@group` annotations.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2014, 9:48 PM
joshuaspence edited edge metadata.
  • Found two more... maybe these functions need to be moved? (I don't really know)
joshuaspence updated this revision to Diff 23678.

Closed by commit rP8756d82cf6c1 (authored by @joshuaspence).