Page MenuHomePhabricator

Remove `@group` annotations
ClosedPublic

Authored by joshuaspence on Jul 8 2014, 12:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 3:09 PM
Unknown Object (File)
Feb 3 2024, 6:47 PM
Unknown Object (File)
Jan 26 2024, 9:23 PM
Unknown Object (File)
Jan 24 2024, 3:18 AM
Unknown Object (File)
Jan 6 2024, 3:49 PM
Unknown Object (File)
Jan 4 2024, 5:38 PM
Unknown Object (File)
Jan 1 2024, 1:39 AM
Unknown Object (File)
Dec 30 2023, 2:45 PM

Details

Summary

I'm pretty sure that @group annotations are useless now... I believe that they were originally used by Diviner?

Test Plan

Eye-balled it.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Remove `@group` annotations.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Yeah, Diviner can figure out @group from configuration now. It's still parsed, but only useful to override the defaults if some file has an unusual grouping for some reason (which nothing in these libraries should, I think).

This revision is now accepted and ready to land.Jul 8 2014, 2:42 PM
In D9855#6, @epriestley wrote:

Yeah, Diviner can figure out @group from configuration now. It's still parsed, but only useful to override the defaults if some file has an unusual grouping for some reason (which nothing in these libraries should, I think).

Is there an easy way to identify these?

I don't have any way to identify them if they do exist. They would have to be weird edge cases that I annotated and then forgot about. If there are any, they're so rare that it's not worth trying to find them. We can add them back if necessary later, but more likely we'd just want to move the code now.

The only case like this that I can think of is all the stuff that used to live in libphutil/src/__phutil_library_init__.php -- moving it out was clearly a better approach.