Page MenuHomePhabricator
Differential D9867

Throw an exception instead of exiting
ClosedPublic
Actions

Authored by joshuaspence on Jul 9 2014, 10:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 11:37 AM
Unknown Object (File)
Mon, Jan 20, 1:51 PM
Unknown Object (File)
Sat, Jan 18, 2:05 AM
Unknown Object (File)
Sun, Jan 12, 5:13 AM
Unknown Object (File)
Thu, Jan 2, 9:24 PM
Unknown Object (File)
Mon, Dec 30, 7:45 PM
Unknown Object (File)
Dec 6 2024, 12:48 AM
Unknown Object (File)
Dec 4 2024, 6:53 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5577: `ArcanistPhutilLibraryLinter` causes `arc lint` to die if there is a PHP syntax error
Commits
rPHU59fa2f8e3910: Throw an exception instead of exiting
Summary

Ref T5577. The PhutilLibraryMapBuilder should throw a XHPASTSyntaxErrorException exception instead of calling exit.

Test Plan

See D9865.

Diff Detail

Repository
rPHU libphutil
Branch
phutillint
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1596
Build 1597: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23673.Jul 9 2014, 10:02 PM
joshuaspence retitled this revision from to Throw an exception instead of exitting.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5577: `ArcanistPhutilLibraryLinter` causes `arc lint` to die if there is a PHP syntax error.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 9 2014, 10:02 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1596: Diff 23673.Jul 9 2014, 10:03 PM
epriestley accepted this revision.Jul 9 2014, 10:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2014, 10:06 PM
joshuaspence retitled this revision from Throw an exception instead of exitting to Throw an exception instead of exiting.Jul 10 2014, 1:42 AM
joshuaspence edited edge metadata.
joshuaspence closed this revision.Jul 10 2014, 1:43 AM
joshuaspence updated this revision to Diff 23685.

Closed by commit rPHU59fa2f8e3910 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
moduleutils/
5 lines

Diff 23673

View Options

src/moduleutils/PhutilLibraryMapBuilder.php

Loading...
Phabricator · Built by Phacility