Page MenuHomePhabricator

Remove `@group` annotations
ClosedPublic

Authored by joshuaspence on Jul 9 2014, 8:51 PM.
Tags
None
Referenced Files
F15516880: D9859.id23678.diff
Fri, Apr 18, 9:59 PM
F15512979: D9859.id23677.largetrue.diff
Thu, Apr 17, 3:25 PM
F15505237: D9859.diff
Tue, Apr 15, 1:08 AM
F15498933: D9859.id23657.diff
Sun, Apr 13, 2:28 PM
F15486788: D9859.id.diff
Thu, Apr 10, 9:41 AM
F15484925: D9859.id23657.diff
Wed, Apr 9, 9:02 PM
F15483852: D9859.id.largetrue.diff
Wed, Apr 9, 2:51 PM
F15481966: D9859.id23678.diff
Wed, Apr 9, 1:29 AM

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP8756d82cf6c1: Remove `@group` annotations
Summary

I'm pretty sure that @group annotations are useless now... see D9855. Also fixed various other minor issues.

Test Plan

Eye-ball it.

Diff Detail

Repository
rP Phabricator
Branch
rm_group
Lint
Lint Warnings
Unit
Tests Passed
Build Status
Buildable 1585
Build 1586: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Remove `@group` annotations.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2014, 9:48 PM
joshuaspence edited edge metadata.
  • Found two more... maybe these functions need to be moved? (I don't really know)
joshuaspence updated this revision to Diff 23678.

Closed by commit rP8756d82cf6c1 (authored by @joshuaspence).