Page MenuHomePhabricator

Remove `@group` annotations
ClosedPublic

Authored by joshuaspence on Jul 9 2014, 8:51 PM.
Tags
None
Referenced Files
F15466837: D9859.id.diff
Thu, Apr 3, 10:18 AM
F15445900: D9859.id23677.diff
Thu, Mar 27, 4:27 PM
F15442817: D9859.id23678.largetrue.diff
Thu, Mar 27, 12:38 AM
F15435245: D9859.diff
Tue, Mar 25, 7:29 AM
F15434623: D9859.diff
Tue, Mar 25, 4:41 AM
F15426764: D9859.id23678.diff
Sun, Mar 23, 10:45 AM
F15421999: D9859.id23677.diff
Sat, Mar 22, 4:23 AM
F15416904: D9859.id23657.diff
Thu, Mar 20, 2:22 PM

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP8756d82cf6c1: Remove `@group` annotations
Summary

I'm pretty sure that @group annotations are useless now... see D9855. Also fixed various other minor issues.

Test Plan

Eye-ball it.

Diff Detail

Repository
rP Phabricator
Branch
rm_group
Lint
Lint Warnings
Unit
Tests Passed
Build Status
Buildable 1585
Build 1586: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Remove `@group` annotations.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2014, 9:48 PM
joshuaspence edited edge metadata.
  • Found two more... maybe these functions need to be moved? (I don't really know)
joshuaspence updated this revision to Diff 23678.

Closed by commit rP8756d82cf6c1 (authored by @joshuaspence).