Page MenuHomePhabricator

Disregard `src/extensions/` when running library map unit tests
ClosedPublic

Authored by epriestley on Jul 5 2014, 9:40 PM.
Tags
None
Referenced Files
F19873133: D9834.diff
Mar 15 2026, 3:32 PM
F19824311: D9834.id.diff
Mar 7 2026, 9:18 PM
F19814521: D9834.diff
Mar 4 2026, 2:15 PM
F19554077: D9834.id23613.diff
Jan 29 2026, 5:11 PM
F19506801: D9834.id23596.diff
Jan 9 2026, 5:07 PM
F18931267: D9834.id23596.diff
Nov 10 2025, 2:43 AM
F18833570: D9834.id23613.diff
Oct 26 2025, 4:30 AM
F18798786: D9834.diff
Oct 17 2025, 8:44 AM
Subscribers

Details

Summary

The runtime map will include anything loaded via src/extensions/, which means the test will always fail if you have anything in that directory.

Instead, allow the base (no extensions) map to be retrieved, and use that for comparisions.

Test Plan
  • Ran unit tests with stuff in extensions.
  • Verified stuff in extensions still works fine.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Disregard `src/extensions/` when running library map unit tests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
This revision is now accepted and ready to land.Jul 5 2014, 10:04 PM
epriestley updated this revision to Diff 23613.

Closed by commit rPHU175694903cee (authored by @epriestley).