Paths

Table of Contentst

Differential D9834

` when running library map unit tests
ClosedPublic
Actions

Authored by epriestley on Jul 5 2014, 9:40 PM.

Details

Reviewers

joshuaspence

Commits

rPHU175694903cee: Disregard `src/extensions/` when running library map unit tests

Summary

The runtime map will include anything loaded via src/extensions/, which means the test will always fail if you have anything in that directory.

Instead, allow the base (no extensions) map to be retrieved, and use that for comparisions.

Test Plan

Ran unit tests with stuff in extensions.
Verified stuff in extensions still works fine.

Diff Detail

Repository

rPHU libphutil

Branch

noext

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1535
Build 1535: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23596.Jul 5 2014, 9:40 PM

epriestley retitled this revision from to Disregard `src/extensions/` when running library map unit tests.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: joshuaspence.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 5 2014, 9:40 PM

Harbormaster completed remote builds in B1535: Diff 23596.Jul 5 2014, 9:41 PM

joshuaspence accepted this revision.Jul 5 2014, 10:04 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Jul 5 2014, 10:04 PM

Closed by commit rPHU175694903cee (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__tests__/

PhutilInfrastructureTestCase.php

2 lines

moduleutils/

PhutilBootloader.php

29 lines

Diff 23596

View Options

src/tests/PhutilInfrastructureTestCase.php

View Options

src/moduleutils/PhutilBootloader.php

Disregard `src/extensions/` when running library map unit testsClosedPublicActions