Page MenuHomePhabricator
Differential D9642

Add phriction.new conduit endpoint
AbandonedPublic
Actions

Authored by artms on Jun 20 2014, 3:40 PM.
Tags
None
Referenced Files
F13232034: D9642.diff
Tue, May 21, 12:58 AM
F13210909: D9642.diff
Fri, May 17, 5:19 AM
F13196626: D9642.diff
Sun, May 12, 11:25 PM
Unknown Object (File)
Tue, May 7, 10:49 AM
Unknown Object (File)
Fri, May 3, 4:36 AM
Unknown Object (File)
Tue, Apr 30, 5:22 PM
Unknown Object (File)
Mon, Apr 29, 3:42 PM
Unknown Object (File)
Sat, Apr 27, 1:10 PM
View All Files
Subscribers
chad
epriestley
joshuaspence
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

After May 29 changes phriction.edit endpoint is unable to create new Phriction pages

Crap, npm log went into

Test Plan

Deployed on our phabricator installation, checked that endpoint is available, it can create phriction pages

Diff Detail

Repository
rP Phabricator
Branch
conduit_phriction_new
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1266
Build 1266: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

artms updated this revision to Diff 23137.Jun 20 2014, 3:40 PM
artms retitled this revision from to Add phriction.new conduit endpoint.
artms updated this object.
artms edited the test plan for this revision. (Show Details)
artms added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 20 2014, 3:40 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1265: Diff 23137.Jun 20 2014, 3:41 PM
artms added inline comments.Jun 20 2014, 3:41 PM
src/applications/phriction/conduit/ConduitAPI_phriction_new_Method.php
45

I did not check - save() checks permissions?

chad added a subscriber: chad.Jun 20 2014, 6:08 PM

You can update /libphutil/ to remove the lint errors

artms updated this revision to Diff 23139.Jun 20 2014, 6:10 PM
artms edited edge metadata.

Fixing lint issues

artms added a comment.Jun 20 2014, 6:11 PM

Thanks @chad for a tip!

Harbormaster completed remote builds in B1266: Diff 23139.Jun 20 2014, 6:11 PM
artms added a comment.Jun 27 2014, 9:55 AM

Any progress?

artms planned changes to this revision.Jan 9 2015, 11:47 AM
artms requested a review of this revision.
joshuaspence added a subscriber: joshuaspence.Mar 1 2015, 7:37 AM
epriestley requested changes to this revision.May 17 2015, 1:34 PM
epriestley edited edge metadata.

This should wait until after T5873 and be rebuilt on top of it.

This revision now requires changes to proceed.May 17 2015, 1:34 PM
artms abandoned this revision.Sep 18 2018, 7:55 AM

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
conduit/
48 lines

Diff 23139

View Options

src/applications/phriction/conduit/ConduitAPI_phriction_new_Method.php

Loading...
Phabricator · Built by Phacility