Differential D9642

Add phriction.new conduit endpoint
AbandonedPublic
Actions

Authored by artms on Jun 20 2014, 3:40 PM.

Tags

None

Referenced Files

	F14950168: D9642.id23137.diff
	Sat, Feb 15, 10:30 PM

	Unknown Object (File)
	Wed, Feb 12, 5:10 AM

	Unknown Object (File)
	Sat, Feb 1, 10:44 PM

	Unknown Object (File)
	Mon, Jan 27, 8:27 PM

	Unknown Object (File)
	Mon, Jan 27, 3:41 PM

	Unknown Object (File)
	Sat, Jan 25, 1:15 PM

	Unknown Object (File)
	Wed, Jan 22, 11:50 PM

	Unknown Object (File)
	Tue, Jan 21, 9:06 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

After May 29 changes phriction.edit endpoint is unable to create new Phriction pages

Crap, npm log went into

Test Plan

Deployed on our phabricator installation, checked that endpoint is available, it can create phriction pages

Diff Detail

Repository

Branch

conduit_phriction_new

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php:26	PHL1	Unknown Symbol
Error	src/applications/differential/customfield/DifferentialAuditorsField.php:25	PHL1	Unknown Symbol
Error	src/applications/differential/customfield/DifferentialJIRAIssuesField.php:31	PHL1	Unknown Symbol
Error	src/applications/metamta/management/PhabricatorMailManagementListInboundWorkflow.php:44	PHL1	Unknown Symbol
Error	src/applications/metamta/management/PhabricatorMailManagementListOutboundWorkflow.php:36	PHL1	Unknown Symbol
Error	src/infrastructure/sms/management/PhabricatorSMSManagementListOutboundWorkflow.php:37	PHL1	Unknown Symbol

Unit

No Test Coverage

Build Status

Buildable 1265
Build 1265: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

artms updated this revision to Diff 23137.Jun 20 2014, 3:40 PM

artms retitled this revision from to Add phriction.new conduit endpoint.

artms updated this object.

artms edited the test plan for this revision. (Show Details)

artms added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 20 2014, 3:40 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1265: Diff 23137.Jun 20 2014, 3:41 PM

artms added inline comments.Jun 20 2014, 3:41 PM

src/applications/phriction/conduit/ConduitAPI_phriction_new_Method.php
44	I did not check - save() checks permissions?

You can update /libphutil/ to remove the lint errors

Fixing lint issues

Thanks @chad for a tip!

Harbormaster completed remote builds in B1266: Diff 23139.Jun 20 2014, 6:11 PM

Any progress?

artms planned changes to this revision.Jan 9 2015, 11:47 AM

artms requested a review of this revision.

joshuaspence added a subscriber: joshuaspence.Mar 1 2015, 7:37 AM

This should wait until after T5873 and be rebuilt on top of it.

This revision now requires changes to proceed.May 17 2015, 1:34 PM

artms abandoned this revision.Sep 18 2018, 7:55 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

conduit/

ConduitAPI_phriction_new_Method.php

48 lines

Diff 23137

src/applications/phriction/conduit/ConduitAPI_phriction_new_Method.php

Loading...