Page MenuHomePhabricator
Differential D9602

Convert `arc feature` to use `PhutilConsoleTable`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 17 2014, 5:19 PM.
Tags
None
Referenced Files
F14035512: D9602.diff
Sun, Nov 10, 6:15 AM
F14033640: D9602.diff
Sat, Nov 9, 6:52 PM
F14021716: D9602.diff
Wed, Nov 6, 11:41 AM
F13970560: D9602.diff
Thu, Oct 17, 8:23 AM
Unknown Object (File)
Oct 2 2024, 2:43 AM
Unknown Object (File)
Sep 25 2024, 6:17 AM
Unknown Object (File)
Sep 8 2024, 3:32 PM
Unknown Object (File)
Aug 27 2024, 3:55 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5110: `arc feature` incorrect indentation for Unicode characters
Commits
rARC7a99e4bc93d9: Convert `arc feature` to use `PhutilConsoleTable`.
Summary

Fixes T5110. PhutilConsoleTable handles Unicode characters and can display a decent-looking table.

Test Plan

`arc_feature`_with_`PhutilConsoleTable` (399×897 px, 129 KB)

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23015.Jun 17 2014, 5:19 PM
joshuaspence retitled this revision from to Convert `arc feature` to use `PhutilConsoleTable`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5110: `arc feature` incorrect indentation for Unicode characters.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 17 2014, 5:19 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1182: Diff 23015.Jun 17 2014, 5:20 PM
joshuaspence added a comment.Jun 17 2014, 5:24 PM

Some thoughts as to future directions for PhutilConsoleTable:

  • We could define color rules for a column, although I'm not sure that this is a good idea (i.e. if the value of a cell in this column is "Accepted" then color it green)
  • We could allow sorting rules to be added.
epriestley accepted this revision.Jun 17 2014, 5:28 PM
epriestley edited edge metadata.

I'm not sure we'd gain all that much by putting colors or sorting into ConsoleTable, but maybe some use cases will pop out somewhere.

This revision is now accepted and ready to land.Jun 17 2014, 5:28 PM
joshuaspence closed this revision.Jun 17 2014, 5:41 PM
joshuaspence updated this revision to Diff 23017.

Closed by commit rARC7a99e4bc93d9 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
workflow/
42 lines

Diff 23017

View Options

src/workflow/ArcanistFeatureWorkflow.php

Loading...
Phabricator · Built by Phacility