Paths

Table of Contentst

Differential D9602

Convert `arc feature` to use `PhutilConsoleTable`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 17 2014, 5:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 24, 7:32 AM

	Unknown Object (File)
	Fri, Nov 22, 5:45 PM

	Unknown Object (File)
	Thu, Nov 21, 9:35 PM

	Unknown Object (File)
	Thu, Nov 21, 8:24 AM

	Unknown Object (File)
	Sun, Nov 17, 4:32 PM

	Unknown Object (File)
	Thu, Nov 14, 3:37 PM

	Unknown Object (File)
	Sun, Nov 10, 7:04 AM

	Unknown Object (File)
	Sun, Nov 10, 6:15 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5110: `arc feature` incorrect indentation for Unicode characters

Commits

rARC7a99e4bc93d9: Convert `arc feature` to use `PhutilConsoleTable`.

Summary

Fixes T5110. PhutilConsoleTable handles Unicode characters and can display a decent-looking table.

Test Plan

`arc_feature`_with_`PhutilConsoleTable` (399×897 px, 129 KB)

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23015.Jun 17 2014, 5:19 PM

joshuaspence retitled this revision from to Convert `arc feature` to use `PhutilConsoleTable`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T5110: `arc feature` incorrect indentation for Unicode characters.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 17 2014, 5:19 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1182: Diff 23015.Jun 17 2014, 5:20 PM

Some thoughts as to future directions for PhutilConsoleTable:

We could define color rules for a column, although I'm not sure that this is a good idea (i.e. if the value of a cell in this column is "Accepted" then color it green)
We could allow sorting rules to be added.

I'm not sure we'd gain all that much by putting colors or sorting into ConsoleTable, but maybe some use cases will pop out somewhere.

This revision is now accepted and ready to land.Jun 17 2014, 5:28 PM

Closed by commit rARC7a99e4bc93d9 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistFeatureWorkflow.php

42 lines

Diff 23017

src/workflow/ArcanistFeatureWorkflow.php

Loading...