Repro:
arc feature foobar arc feature ಠ_ಠ arc feature baz arc feature
Result:
foobar Committed D..... master Committed D..... * baz Committed D..... ಠ_ಠ Committed D.....
Notice indentation of last line is incorrect and is missing a few spaces.
Description
Description
Revisions and Commits
Revisions and Commits
| rARC Arcanist | |||
| D9602 | rARC7a99e4bc93d9 Convert `arc feature` to use `PhutilConsoleTable`. | ||
Event Timeline
Comment Actions
phutil_utf8_console_strlen() might not be handling these correctly, or we might be using normal strlen() instead of phutil_utf8_console_strlen().
Comment Actions
To fix this:
- Switch rendering to use PhutilConsoleTable, which handles all this spacing/measuring correctly, including utf8 string and display lengths.
- It might need some tweaks to deal with console color escape sequences?
- There should be some options already for rendering a table with no padding so the result is approximately similar to the current output.