Fixes T5110. PhutilConsoleTable handles Unicode characters and can display a decent-looking table.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T5110: `arc feature` incorrect indentation for Unicode characters
- Commits
- rARC7a99e4bc93d9: Convert `arc feature` to use `PhutilConsoleTable`.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- featuretable
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1182 Build 1182: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Some thoughts as to future directions for PhutilConsoleTable:
- We could define color rules for a column, although I'm not sure that this is a good idea (i.e. if the value of a cell in this column is "Accepted" then color it green)
- We could allow sorting rules to be added.
Comment Actions
I'm not sure we'd gain all that much by putting colors or sorting into ConsoleTable, but maybe some use cases will pop out somewhere.