Page MenuHomePhabricator

Convert `arc feature` to use `PhutilConsoleTable`.
ClosedPublic

Authored by joshuaspence on Jun 17 2014, 5:19 PM.
Tags
None
Referenced Files
F14033640: D9602.diff
Sat, Nov 9, 6:52 PM
F14021716: D9602.diff
Wed, Nov 6, 11:41 AM
F13970560: D9602.diff
Thu, Oct 17, 8:23 AM
Unknown Object (File)
Oct 2 2024, 2:43 AM
Unknown Object (File)
Sep 25 2024, 6:17 AM
Unknown Object (File)
Sep 8 2024, 3:32 PM
Unknown Object (File)
Aug 27 2024, 3:55 AM
Unknown Object (File)
Aug 19 2024, 8:59 AM
Subscribers

Details

Summary

Fixes T5110. PhutilConsoleTable handles Unicode characters and can display a decent-looking table.

Test Plan

`arc_feature`_with_`PhutilConsoleTable` (399×897 px, 129 KB)

Diff Detail

Repository
rARC Arcanist
Branch
featuretable
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1182
Build 1182: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Convert `arc feature` to use `PhutilConsoleTable`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

Some thoughts as to future directions for PhutilConsoleTable:

  • We could define color rules for a column, although I'm not sure that this is a good idea (i.e. if the value of a cell in this column is "Accepted" then color it green)
  • We could allow sorting rules to be added.
epriestley edited edge metadata.

I'm not sure we'd gain all that much by putting colors or sorting into ConsoleTable, but maybe some use cases will pop out somewhere.

This revision is now accepted and ready to land.Jun 17 2014, 5:28 PM