Paths

Table of Contentst

Differential D9348

Fix lint when working on windows
ClosedPublic
Actions

Authored by richardvanvelzen on Jun 2 2014, 8:59 PM.

Tags

None

Referenced Files

	F13216767: D9348.id22378.diff
	Sat, May 18, 2:08 AM

	F13212958: D9348.id.diff
	Fri, May 17, 7:13 AM

	F13188359: D9348.diff
	Sat, May 11, 5:12 AM

	F13176270: D9348.diff
	Wed, May 8, 12:15 PM

	Unknown Object (File)
	Tue, May 7, 7:42 AM

	Unknown Object (File)
	Fri, May 3, 9:32 AM

	Unknown Object (File)
	Fri, May 3, 9:32 AM

	Unknown Object (File)
	Fri, May 3, 6:49 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4592: Use mingw to rebuild xhpast.exe on Windows
T4395: ArcanistPhpcsLinter issue with msdos and cygwin

Commits

rPHU3fe4daa19d2c: Fix lint when working on windows

Summary

Fixes T4395.

Add quotes to ExecFuture strings on Windows to prevent cmd.exe from mucking up the command string.

Test Plan

Run arc lint on projects using phpcs. See everything working like it should.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 803
Build 803: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

richardvanvelzen updated this revision to Diff 22257.Jun 2 2014, 8:59 PM

richardvanvelzen retitled this revision from to Fixes T4395. Ref T4592..

richardvanvelzen updated this object.

richardvanvelzen edited the test plan for this revision. (Show Details)

richardvanvelzen added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2014, 8:59 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

richardvanvelzen retitled this revision from Fixes T4395. Ref T4592. to Fix lint when working on windows.Jun 2 2014, 8:59 PM

richardvanvelzen updated this object.

richardvanvelzen edited edge metadata.

richardvanvelzen added tasks: T4395: ArcanistPhpcsLinter issue with msdos and cygwin, T4592: Use mingw to rebuild xhpast.exe on Windows.

Harbormaster completed remote builds in B803: Diff 22257.Jun 2 2014, 9:00 PM

I'll accept the quoting change if you expand the comment a little to summarize the issue (it should still link to T4395, but be slightly more descriptive).

Can you briefly walk me through the xhpast.exe rebuild? Not that I don't trust you, but I'd rather build binaries we ship from source. I'll take a shot at this locally and yell if I get stuck.

This revision now requires changes to proceed.Jun 4 2014, 9:26 PM

(D9378 has a .exe rebuild that I have chain-of-custody on.)

Remove the rebuild xhpast.exe and expand the comment a bit.

Harbormaster completed remote builds in B865: Diff 22378.Jun 5 2014, 5:53 AM

richardvanvelzen updated this object.Jun 5 2014, 5:53 AM

richardvanvelzen edited the test plan for this revision. (Show Details)

richardvanvelzen edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Jun 5 2014, 4:40 PM

Closed by commit rPHU3fe4daa19d2c (authored by @richardvanvelzen, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

future/

exec/

7 lines

parser/

xhpast/

bin/

Diff 22257

src/future/exec/ExecFuture.php

Loading...

src/parser/xhpast/bin/xhpast.exe

Loading...