Page MenuHomePhabricator
Differential D9247

Capture a wider range of version information in `php_compat_info.json`.
ClosedPublic
Actions

Authored by joshuaspence on May 21 2014, 9:34 PM.
Tags
None
Referenced Files
F13283067: D9247.diff
Sun, Jun 2, 12:46 PM
F13270504: D9247.id21962.diff
Wed, May 29, 9:49 AM
F13270259: D9247.diff
Wed, May 29, 9:26 AM
F13221024: D9247.diff
Sun, May 19, 2:13 AM
F13208355: D9247.id21962.diff
Thu, May 16, 2:30 PM
F13202973: D9247.diff
Tue, May 14, 11:22 PM
F13188649: D9247.diff
Sat, May 11, 5:23 AM
Unknown Object (File)
Tue, May 7, 7:24 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5141: `ArcanistXHPASTLinter` should raise warnings when deprecated functions are used
Commits
rARCf13aa21b8eed: Capture a wider range of version information in `php_compat_info.json`.
Summary

Ref T5141. Currently, php_compat_info.json is hardcoded to support PHP 5.2.3. Instead, store as much version information as possible in php_compat_info.json and filter accordingly in ArcanistXHPASTLinter.

Test Plan

Ran arc lint and made sure no additional warnings were raised.

Diff Detail

Repository
rARC Arcanist
Branch
php_compat_info
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 641
Build 641: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21962.May 21 2014, 9:34 PM
joshuaspence retitled this revision from to Capture a wider range of version information in `php_compat_info.json`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5141: `ArcanistXHPASTLinter` should raise warnings when deprecated functions are used.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 21 2014, 9:34 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B641: Diff 21962.May 21 2014, 9:36 PM
epriestley accepted this revision.May 22 2014, 4:14 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 22 2014, 4:14 PM
epriestley closed this revision.May 22 2014, 4:14 PM
epriestley updated this revision to Diff 21975.

Closed by commit rARCf13aa21b8eed (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
3560 lines
scripts/
9 lines
src/
lint/
linter/
7 lines

Diff 21962

View Options

resources/php_compat_info.json

Loading...
View Options

scripts/update_compat_info.php

Loading...
View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
Phabricator · Built by Phacility