Page MenuHomePhabricator
Differential D9248

Capture maximum version information in `php_compat_info`.
ClosedPublic
Actions

Authored by joshuaspence on May 21 2014, 9:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 14, 11:28 PM
Unknown Object (File)
Sat, Sep 14, 11:27 PM
Unknown Object (File)
Sat, Sep 14, 11:27 PM
Unknown Object (File)
Sat, Sep 14, 11:25 PM
Unknown Object (File)
Wed, Sep 4, 9:02 PM
Unknown Object (File)
Wed, Sep 4, 12:57 PM
Unknown Object (File)
Mon, Aug 26, 11:06 AM
Unknown Object (File)
Sun, Aug 25, 9:55 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5141: `ArcanistXHPASTLinter` should raise warnings when deprecated functions are used
Commits
rARCe0ee3e8a07ba: Capture maximum version information in `php_compat_info`.
Summary

Ref T5141. In order to be able to warn when deprecated functions are used, we need to be aware of from which version the functions were deprecated.

Test Plan

Ran arc lint and made sure no unexpected warnings were raised.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21963.May 21 2014, 9:43 PM
joshuaspence retitled this revision from to Capture maximum version information in `php_compat_info`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5141: `ArcanistXHPASTLinter` should raise warnings when deprecated functions are used.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 21 2014, 9:43 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B642: Diff 21963.May 21 2014, 9:44 PM
epriestley edited edge metadata.May 21 2014, 9:46 PM

How long does parsing a 14,000 line JSON file take?

joshuaspence added a comment.May 21 2014, 9:50 PM

Before

> time php -r 'json_decode(file_get_contents("./resources/php_compat_info.json"), true);'

real	0m0.027s
user	0m0.018s
sys	0m0.009s

After

> time php -r 'json_decode(file_get_contents("./resources/php_compat_info.json"), true);'

real	0m0.034s
user	0m0.024s
sys	0m0.010s
joshuaspence added a parent revision: D9247: Capture a wider range of version information in `php_compat_info.json`..May 21 2014, 9:51 PM
epriestley accepted this revision.May 22 2014, 4:14 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 22 2014, 4:14 PM
epriestley closed this revision.May 22 2014, 4:22 PM
epriestley updated this revision to Diff 21976.

Closed by commit rARCe0ee3e8a07ba (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
15945 lines
scripts/
6 lines
src/
lint/
linter/
4 lines

Diff 21976

View Options

resources/php_compat_info.json

Loading...
View Options

scripts/update_compat_info.php

Loading...
View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
Phabricator · Built by Phacility