Page MenuHomePhabricator

Capture a wider range of version information in `php_compat_info.json`.
ClosedPublic

Authored by joshuaspence on May 21 2014, 9:34 PM.
Tags
None
Referenced Files
F15413017: D9247.diff
Wed, Mar 19, 4:23 PM
F15360519: D9247.id21962.diff
Tue, Mar 11, 8:47 AM
F15337833: D9247.id21962.diff
Sun, Mar 9, 7:52 AM
Unknown Object (File)
Mon, Mar 3, 2:49 AM
Unknown Object (File)
Feb 9 2025, 1:07 PM
Unknown Object (File)
Feb 9 2025, 1:07 PM
Unknown Object (File)
Feb 9 2025, 1:07 PM
Unknown Object (File)
Feb 1 2025, 2:23 AM
Subscribers

Details

Summary

Ref T5141. Currently, php_compat_info.json is hardcoded to support PHP 5.2.3. Instead, store as much version information as possible in php_compat_info.json and filter accordingly in ArcanistXHPASTLinter.

Test Plan

Ran arc lint and made sure no additional warnings were raised.

Diff Detail

Repository
rARC Arcanist
Branch
php_compat_info
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 641
Build 641: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Capture a wider range of version information in `php_compat_info.json`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 22 2014, 4:14 PM
epriestley updated this revision to Diff 21975.

Closed by commit rARCf13aa21b8eed (authored by @joshuaspence, committed by @epriestley).