Page MenuHomePhabricator

Disable the edit/quote menu for non-standard comments
ClosedPublic

Authored by epriestley on May 18 2014, 12:38 PM.
Tags
None
Referenced Files
F14481254: D9180.diff
Mon, Dec 30, 1:48 AM
Unknown Object (File)
Sat, Dec 28, 9:51 PM
Unknown Object (File)
Sun, Dec 15, 1:52 AM
Unknown Object (File)
Sat, Dec 14, 3:27 PM
Unknown Object (File)
Tue, Dec 10, 2:39 AM
Unknown Object (File)
Sat, Nov 30, 11:37 PM
Unknown Object (File)
Nov 28 2024, 1:11 PM
Unknown Object (File)
Nov 28 2024, 1:10 PM

Details

Summary

Fixes T4930. We currently show the edit/quote menu if a transaction group has inline comments, but this doesn't make sense and doesn't work properly. Only show this menu if the group has a normal comment.

Test Plan

Viewed these groups:

  • Normal comment (edits fine).
  • Just inlines (no more edit menu).
  • Inline + comment (edits fine, affects the normal comment properly).

Diff Detail

Repository
rP Phabricator
Branch
inlineedit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 550
Build 550: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Disable the edit/quote menu for non-standard comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 6:53 PM
epriestley updated this revision to Diff 21855.

Closed by commit rP703e0b396888 (authored by @epriestley).