Page MenuHomePhabricator

Disable the edit/quote menu for non-standard comments
ClosedPublic

Authored by epriestley on May 18 2014, 12:38 PM.
Tags
None
Referenced Files
F15450182: D9180.id21855.diff
Fri, Mar 28, 2:24 PM
F15427600: D9180.id21803.diff
Sun, Mar 23, 3:09 PM
F15414238: D9180.id21803.diff
Wed, Mar 19, 11:37 PM
F15409383: D9180.id21803.diff
Wed, Mar 19, 4:28 AM
F15383107: D9180.id21855.diff
Fri, Mar 14, 3:35 PM
F15377160: D9180.id21803.diff
Thu, Mar 13, 8:19 AM
F15331935: D9180.id21803.diff
Fri, Mar 7, 3:31 PM
Unknown Object (File)
Mar 2 2025, 3:48 AM

Details

Summary

Fixes T4930. We currently show the edit/quote menu if a transaction group has inline comments, but this doesn't make sense and doesn't work properly. Only show this menu if the group has a normal comment.

Test Plan

Viewed these groups:

  • Normal comment (edits fine).
  • Just inlines (no more edit menu).
  • Inline + comment (edits fine, affects the normal comment properly).

Diff Detail

Repository
rP Phabricator
Branch
inlineedit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 550
Build 550: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Disable the edit/quote menu for non-standard comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 6:53 PM
epriestley updated this revision to Diff 21855.

Closed by commit rP703e0b396888 (authored by @epriestley).