Page MenuHomePhabricator

Use RepositoryGraphCache to service diffusion.lastmodifiedquery
ClosedPublic

Authored by epriestley on May 11 2014, 12:29 AM.
Tags
None
Referenced Files
F14033420: D9047.id21572.diff
Sat, Nov 9, 5:37 PM
F14033419: D9047.id21488.diff
Sat, Nov 9, 5:37 PM
F14033417: D9047.id.diff
Sat, Nov 9, 5:37 PM
F14024528: D9047.diff
Thu, Nov 7, 10:22 AM
F14020557: D9047.diff
Wed, Nov 6, 12:43 AM
F13996097: D9047.diff
Wed, Oct 23, 5:59 PM
F13976327: D9047.diff
Fri, Oct 18, 1:47 PM
F13973549: D9047.id21488.diff
Fri, Oct 18, 1:22 AM

Details

Summary

Ref T2683. At least locally, browse views are now nearly instantaneous, even in Mercurial. We also fall back to what we were doing before if we miss or take too long, so this shouldn't make things very much worse even in extreme cases.

For a local hg repo, the time we spend pulling browse stuff has dropped from ~3,000ms to ~20ms. This is probably atypical, but not completely crazy or rigged or anything.

Test Plan

Viewed Git, Subversion and Mercurial repositories and observed dramatically better performance in Git and Mercurial as they took advantage of the cache.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Use RepositoryGraphCache to service diffusion.lastmodifiedquery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: jhurwitz.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 12 2014, 6:27 PM
src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php
203

maybe this should be a class constant? just a little hidden-ish, nbd

epriestley updated this revision to Diff 21572.

Closed by commit rPe13369d20815 (authored by @epriestley).