Page MenuHomePhabricator

Use RepositoryGraphCache to service diffusion.lastmodifiedquery
ClosedPublic

Authored by epriestley on May 11 2014, 12:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 5:45 PM
Unknown Object (File)
Tue, Dec 17, 11:12 AM
Unknown Object (File)
Thu, Dec 12, 11:22 PM
Unknown Object (File)
Tue, Dec 10, 7:06 AM
Unknown Object (File)
Sat, Dec 7, 8:56 PM
Unknown Object (File)
Thu, Nov 28, 12:50 PM
Unknown Object (File)
Thu, Nov 28, 2:29 AM
Unknown Object (File)
Wed, Nov 27, 4:10 AM

Details

Summary

Ref T2683. At least locally, browse views are now nearly instantaneous, even in Mercurial. We also fall back to what we were doing before if we miss or take too long, so this shouldn't make things very much worse even in extreme cases.

For a local hg repo, the time we spend pulling browse stuff has dropped from ~3,000ms to ~20ms. This is probably atypical, but not completely crazy or rigged or anything.

Test Plan

Viewed Git, Subversion and Mercurial repositories and observed dramatically better performance in Git and Mercurial as they took advantage of the cache.

Diff Detail

Repository
rP Phabricator
Branch
gcache7
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 356
Build 356: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Use RepositoryGraphCache to service diffusion.lastmodifiedquery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: jhurwitz.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 12 2014, 6:27 PM
src/applications/repository/graphcache/PhabricatorRepositoryGraphCache.php
203

maybe this should be a class constant? just a little hidden-ish, nbd

epriestley updated this revision to Diff 21572.

Closed by commit rPe13369d20815 (authored by @epriestley).