Page MenuHomePhabricator

Use the `ArcanistConfigurationDrivenLintEngine` as a linting engine.
ClosedPublic

Authored by joshuaspence on May 11 2014, 9:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 4, 11:52 PM
Unknown Object (File)
Mon, Mar 4, 8:24 AM
Unknown Object (File)
Jan 28 2024, 11:07 PM
Unknown Object (File)
Jan 19 2024, 12:59 AM
Unknown Object (File)
Dec 27 2023, 1:21 AM
Unknown Object (File)
Dec 21 2023, 2:10 AM
Unknown Object (File)
Dec 16 2023, 5:46 PM
Unknown Object (File)
Nov 23 2023, 12:58 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
Restricted Maniphest Task
Commits
rARCb63828a87eb2: Use the `ArcanistConfigurationDrivenLintEngine` as a linting engine.
Summary

Ref T2039. The .arclint file is reasonably complete now and we should start using it if possible, since we are trying to recommend it to others.

Test Plan

arc lint.

Diff Detail

Repository
rARC Arcanist
Branch
arclint
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 369
Build 369: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Use the `ArcanistConfigurationDrivenLintEngine` as a linting engine..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: Restricted Maniphest Task.
src/lint/linter/ArcanistPhutilXHPASTLinter.php
36

I'm not sure if this is okay...

One thing that will definitely be annoying will be duplicating an .arclint file across Arcanist, libphutil and Phabricator.

.arcconfig
4

Just omit this given that .arclint is present.

src/lint/linter/ArcanistPhutilXHPASTLinter.php
36

I think this will cause us to lint everything twice -- currently, we can run the linter once and reuse the results. Let me fiddle with this a bit; I guess we can put some kind of shared storage on the Engine, maybe.

joshuaspence edited edge metadata.

Don't explicitly specify lint.engine as it is implied.

I will probably need to rebase this after D9059.

epriestley edited edge metadata.
This revision is now accepted and ready to land.May 12 2014, 2:31 AM
epriestley updated this revision to Diff 21521.

Closed by commit rARCb63828a87eb2 (authored by @joshuaspence, committed by @epriestley).