Paths

Table of Contentst

Differential D9057

Use the `ArcanistConfigurationDrivenLintEngine` as a linting engine.
ClosedPublic
Actions

Authored by joshuaspence on May 11 2014, 9:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 1:23 PM

	Unknown Object (File)
	Thu, Dec 12, 3:29 PM

	Unknown Object (File)
	Wed, Dec 11, 8:09 PM

	Unknown Object (File)
	Tue, Dec 10, 9:47 PM

	Unknown Object (File)
	Sun, Dec 8, 4:54 PM

	Unknown Object (File)
	Sun, Dec 8, 4:54 PM

	Unknown Object (File)
	Sun, Dec 8, 4:54 PM

	Unknown Object (File)
	Sun, Dec 8, 4:54 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

rARCb63828a87eb2: Use the `ArcanistConfigurationDrivenLintEngine` as a linting engine.

Summary

Ref T2039. The .arclint file is reasonably complete now and we should start using it if possible, since we are trying to recommend it to others.

Test Plan

arc lint.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21504.May 11 2014, 9:44 PM

joshuaspence retitled this revision from to Use the `ArcanistConfigurationDrivenLintEngine` as a linting engine..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: Restricted Maniphest Task.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 11 2014, 9:44 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B369: Diff 21504.May 11 2014, 9:45 PM

joshuaspence added inline comments.May 11 2014, 9:45 PM

src/lint/linter/ArcanistPhutilXHPASTLinter.php
27–28	I'm not sure if this is okay...

One thing that will definitely be annoying will be duplicating an .arclint file across Arcanist, libphutil and Phabricator.

epriestley added inline comments.May 11 2014, 11:23 PM

.arcconfig
3–4	Just omit this given that `.arclint` is present.
src/lint/linter/ArcanistPhutilXHPASTLinter.php
27–28	I think this will cause us to lint everything twice -- currently, we can run the linter once and reuse the results. Let me fiddle with this a bit; I guess we can put some kind of shared storage on the Engine, maybe.

joshuaspence added a parent revision: D9059: Allow linters to share resources by shoving them on the Engine.May 12 2014, 1:27 AM

Don't explicitly specify lint.engine as it is implied.

I will probably need to rebase this after D9059.

Harbormaster completed remote builds in B374: Diff 21511.May 12 2014, 1:28 AM

Rebased after D9059.

epriestley accepted this revision.May 12 2014, 2:31 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 12 2014, 2:31 AM

Harbormaster completed remote builds in B378: Diff 21518.May 12 2014, 2:32 AM

Closed by commit rARCb63828a87eb2 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

1 line

41 lines

src/

lint/

linter/

ArcanistPhutilXHPASTLinter.php

4 lines

ArcanistXHPASTLinter.php

4 lines

Diff 21521

.arcconfig

Loading...

.arclint

Loading...

src/lint/linter/ArcanistPhutilXHPASTLinter.php

Loading...

src/lint/linter/ArcanistXHPASTLinter.php

Loading...