Page MenuHomePhabricator

Use the `ArcanistConfigurationDrivenLintEngine` as a linting engine.
ClosedPublic

Authored by joshuaspence on May 11 2014, 9:44 PM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
Restricted Maniphest Task
Commits
rARCb63828a87eb2: Use the `ArcanistConfigurationDrivenLintEngine` as a linting engine.
Summary

Ref T2039. The .arclint file is reasonably complete now and we should start using it if possible, since we are trying to recommend it to others.

Test Plan

arc lint.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Use the `ArcanistConfigurationDrivenLintEngine` as a linting engine..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: Restricted Maniphest Task.
joshuaspence added inline comments.May 11 2014, 9:45 PM
src/lint/linter/ArcanistPhutilXHPASTLinter.php
27–28

I'm not sure if this is okay...

One thing that will definitely be annoying will be duplicating an .arclint file across Arcanist, libphutil and Phabricator.

epriestley added inline comments.May 11 2014, 11:23 PM
.arcconfig
3–4

Just omit this given that .arclint is present.

src/lint/linter/ArcanistPhutilXHPASTLinter.php
27–28

I think this will cause us to lint everything twice -- currently, we can run the linter once and reuse the results. Let me fiddle with this a bit; I guess we can put some kind of shared storage on the Engine, maybe.

joshuaspence edited edge metadata.

Don't explicitly specify lint.engine as it is implied.

joshuaspence planned changes to this revision.May 12 2014, 1:28 AM

I will probably need to rebase this after D9059.

Rebased after D9059.

epriestley accepted this revision.May 12 2014, 2:31 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 12 2014, 2:31 AM
epriestley closed this revision.May 12 2014, 2:34 AM
epriestley updated this revision to Diff 21521.

Closed by commit rARCb63828a87eb2 (authored by @joshuaspence, committed by @epriestley).