Page MenuHomePhabricator

Create file controller in Phragment
AbandonedPublic

Authored by hach-que on Apr 2 2014, 8:35 AM.
Tags
None
Referenced Files
F13239651: D8672.diff
Wed, May 22, 5:22 AM
F13213769: D8672.id20561.diff
Fri, May 17, 8:04 AM
F13211084: D8672.diff
Fri, May 17, 5:28 AM
F13207419: D8672.diff
Wed, May 15, 11:25 PM
F13194453: D8672.diff
Sun, May 12, 9:35 PM
F13191347: D8672.id24555.diff
Sat, May 11, 7:40 PM
F13191345: D8672.id20561.diff
Sat, May 11, 7:40 PM
F13191293: D8672.diff
Sat, May 11, 7:11 PM

Details

Summary

This provides a controller similar to the ZIP controller, except that it's meant for us on fragments that you want to download as a file. This controller provides a consistent URL (that can optionally contain a snapshot) which will be correct when and if a fragment gets updated, unlike the raw file link.

It also adds "Download Snapshot" on the snapshot controller, which links to the file controller with the snapshot name included.

Test Plan

Downloaded file-based fragments from the new controller.

Diff Detail

Repository
rP Phabricator
Branch
phragment-redirect-link
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:41PHL1Unknown Symbol
Errorsrc/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:49PHL1Unknown Symbol
Errorsrc/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:53PHL1Unknown Symbol
Unit
No Test Coverage

Event Timeline

hach-que retitled this revision from to Create file controller in Phragment.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que edited edge metadata.

Rebase on master

Might as well abandon this as we're no longer using it in production (and is probably still years away on the upstream roadmap).