Page MenuHomePhabricator

Fix Mailgun Reply-To handling
ClosedPublic

Authored by carl on Mar 29 2014, 5:50 PM.
Tags
None
Referenced Files
F15463478: D8645.id20502.diff
Tue, Apr 1, 11:58 PM
F15462277: D8645.id.diff
Tue, Apr 1, 1:38 PM
F15461219: D8645.id20501.diff
Tue, Apr 1, 6:17 AM
F15459205: D8645.diff
Mon, Mar 31, 10:53 AM
F15375748: D8645.id20501.diff
Wed, Mar 12, 11:59 PM
Unknown Object (File)
Feb 21 2025, 11:48 AM
Unknown Object (File)
Feb 21 2025, 11:48 AM
Unknown Object (File)
Feb 11 2025, 2:15 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP213eea7bdd00: Fix Mailgun Reply-To handling
Summary

When sending the "Reply-To" header to Mailgun, Phabricator would
previously send two headers for every "Reply-To": "Reply-To[0][email]" and
"Reply-To[0][name]". Instead, explicitly build the header as specified by RFC
2822 and send it to Mailgun pre-baked.

Pretty sure this bug was a cargo-cult from the Sendgrid code, where (apparently)
this actually works.

Test Plan

Triggered an email from Phabricator, saw that the header was sent
properly.

Diff Detail

Repository
rP Phabricator
Branch
mailgun-reply-to
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

carl retitled this revision from to Fix Mailgun Reply-To handling.
carl updated this object.
carl edited the test plan for this revision. (Show Details)
carl added a reviewer: epriestley.
This revision is now accepted and ready to land.Mar 29 2014, 5:52 PM
epriestley updated this revision to Diff 20502.

Closed by commit rP213eea7bdd00 (authored by @carl, committed by @epriestley).