Fix Mailgun Reply-To handling
ClosedPublic
Actions

Authored by carl on Mar 29 2014, 5:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 15, 9:58 PM

	Unknown Object (File)
	Tue, Apr 9, 5:06 AM

	Unknown Object (File)
	Fri, Apr 5, 10:49 PM

	Unknown Object (File)
	Fri, Apr 5, 10:49 PM

	Unknown Object (File)
	Fri, Apr 5, 10:25 PM

	Unknown Object (File)
	Fri, Apr 5, 9:59 PM

	Unknown Object (File)
	Thu, Apr 4, 8:24 AM

	Unknown Object (File)
	Thu, Apr 4, 4:38 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP213eea7bdd00: Fix Mailgun Reply-To handling

Summary

When sending the "Reply-To" header to Mailgun, Phabricator would
previously send two headers for every "Reply-To": "Reply-To[0][email]" and
"Reply-To[0][name]". Instead, explicitly build the header as specified by RFC
2822 and send it to Mailgun pre-baked.

Pretty sure this bug was a cargo-cult from the Sendgrid code, where (apparently)
this actually works.

Test Plan

Triggered an email from Phabricator, saw that the header was sent
properly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

carl updated this revision to Diff 20501.Mar 29 2014, 5:50 PM

carl retitled this revision from to Fix Mailgun Reply-To handling.

carl updated this object.

carl edited the test plan for this revision. (Show Details)

carl added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers.Mar 29 2014, 5:50 PM

Herald added subscribers: Korvin, epriestley.

Thanks!

This revision is now accepted and ready to land.Mar 29 2014, 5:52 PM

Closed by commit rP213eea7bdd00 (authored by @carl, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

adapter/

PhabricatorMailImplementationMailgunAdapter.php

7 lines

Diff 20502

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php

Fix Mailgun Reply-To handlingClosedPublicActions