Page MenuHomePhabricator

Fix Mailgun Reply-To handling
ClosedPublic

Authored by carl on Mar 29 2014, 5:50 PM.
Tags
None
Referenced Files
F14062792: D8645.diff
Mon, Nov 18, 2:33 PM
F14048313: D8645.diff
Thu, Nov 14, 7:27 AM
F14039077: D8645.id20502.diff
Mon, Nov 11, 3:40 AM
F14032924: D8645.diff
Sat, Nov 9, 4:12 PM
F14003555: D8645.id.diff
Sat, Oct 26, 7:30 AM
F14003525: D8645.id.diff
Sat, Oct 26, 7:09 AM
F13989586: D8645.id20502.diff
Mon, Oct 21, 9:32 PM
F13984964: D8645.id20501.diff
Sun, Oct 20, 5:13 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP213eea7bdd00: Fix Mailgun Reply-To handling
Summary

When sending the "Reply-To" header to Mailgun, Phabricator would
previously send two headers for every "Reply-To": "Reply-To[0][email]" and
"Reply-To[0][name]". Instead, explicitly build the header as specified by RFC
2822 and send it to Mailgun pre-baked.

Pretty sure this bug was a cargo-cult from the Sendgrid code, where (apparently)
this actually works.

Test Plan

Triggered an email from Phabricator, saw that the header was sent
properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

carl retitled this revision from to Fix Mailgun Reply-To handling.
carl updated this object.
carl edited the test plan for this revision. (Show Details)
carl added a reviewer: epriestley.
This revision is now accepted and ready to land.Mar 29 2014, 5:52 PM
epriestley updated this revision to Diff 20502.

Closed by commit rP213eea7bdd00 (authored by @carl, committed by @epriestley).