Page MenuHomePhabricator

Extract textual object list parsing from Differential
ClosedPublic

Authored by epriestley on Mar 8 2014, 12:01 AM.
Tags
None
Referenced Files
F14067036: D8445.diff
Tue, Nov 19, 1:00 PM
F14050403: D8445.diff
Thu, Nov 14, 6:36 PM
F14049082: D8445.id20047.diff
Thu, Nov 14, 10:50 AM
F14047569: D8445.id20040.diff
Thu, Nov 14, 4:29 AM
F14044316: D8445.id20040.diff
Tue, Nov 12, 3:43 PM
F14038512: D8445.id20047.diff
Mon, Nov 11, 12:07 AM
F14016205: D8445.id20047.diff
Mon, Nov 4, 7:10 AM
F14012380: D8445.diff
Fri, Nov 1, 11:12 AM
Subscribers

Details

Summary

Ref T2222. Currently, Differential has a fairly hairy piece of logic to parse object lists, like Reviewers: alincoln, htaft. Extract, generalize, and cover this.

  • Some of the logic can be simplified with modern ObjectQuery stuff.
  • Make @username the formal monogram for users.
  • Make list@domain.com the formal monogram for mailing lists.
  • Add test coverage.
Test Plan
  • Ran unit tests.
  • Called differential.parsecommitmessage with a bunch of real-world inputs and got sensible results.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 8 2014, 12:41 AM