Page MenuHomePhabricator

Extract textual object list parsing from Differential
ClosedPublic

Authored by epriestley on Mar 8 2014, 12:01 AM.
Tags
None
Referenced Files
F14357293: D8445.diff
Fri, Dec 20, 3:49 AM
Unknown Object (File)
Fri, Dec 13, 10:42 AM
Unknown Object (File)
Mon, Dec 9, 4:18 PM
Unknown Object (File)
Thu, Dec 5, 8:19 PM
Unknown Object (File)
Sun, Dec 1, 9:40 AM
Unknown Object (File)
Wed, Nov 27, 12:05 PM
Unknown Object (File)
Tue, Nov 26, 4:24 PM
Unknown Object (File)
Tue, Nov 26, 10:40 AM
Subscribers

Details

Summary

Ref T2222. Currently, Differential has a fairly hairy piece of logic to parse object lists, like Reviewers: alincoln, htaft. Extract, generalize, and cover this.

  • Some of the logic can be simplified with modern ObjectQuery stuff.
  • Make @username the formal monogram for users.
  • Make list@domain.com the formal monogram for mailing lists.
  • Add test coverage.
Test Plan
  • Ran unit tests.
  • Called differential.parsecommitmessage with a bunch of real-world inputs and got sensible results.

Diff Detail

Repository
rP Phabricator
Branch
dx9
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 8 2014, 12:41 AM