Page MenuHomePhabricator

Extract textual object list parsing from Differential
ClosedPublic

Authored by epriestley on Mar 8 2014, 12:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 14, 2:30 PM
Unknown Object (File)
Mon, Jun 9, 2:02 AM
Unknown Object (File)
May 20 2025, 9:24 AM
Unknown Object (File)
May 19 2025, 10:35 PM
Unknown Object (File)
May 10 2025, 12:51 PM
Unknown Object (File)
May 8 2025, 11:56 AM
Unknown Object (File)
May 5 2025, 6:10 AM
Unknown Object (File)
Apr 17 2025, 10:57 PM
Subscribers

Details

Summary

Ref T2222. Currently, Differential has a fairly hairy piece of logic to parse object lists, like Reviewers: alincoln, htaft. Extract, generalize, and cover this.

  • Some of the logic can be simplified with modern ObjectQuery stuff.
  • Make @username the formal monogram for users.
  • Make list@domain.com the formal monogram for mailing lists.
  • Add test coverage.
Test Plan
  • Ran unit tests.
  • Called differential.parsecommitmessage with a bunch of real-world inputs and got sensible results.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 8 2014, 12:41 AM