Use PHP type hinting in `ArcanistXHPASTLinter`.
ClosedPublic
Actions

Authored by joshuaspence on Mar 3 2014, 11:36 AM.

Tags

None

Referenced Files

	F15458440: D8388.id.diff
	Mon, Mar 31, 2:15 AM

	F15425578: D8388.id19935.diff
	Sun, Mar 23, 4:57 AM

	Unknown Object (File)
	Feb 23 2025, 10:19 PM

	Unknown Object (File)
	Feb 19 2025, 11:04 PM

	Unknown Object (File)
	Feb 15 2025, 9:41 AM

	Unknown Object (File)
	Feb 15 2025, 9:41 AM

	Unknown Object (File)
	Feb 15 2025, 9:41 AM

	Unknown Object (File)
	Feb 15 2025, 9:41 AM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC0888b6616cbe: Use PHP type hinting in `ArcanistXHPASTLinter`.

Summary

Explicitly specify the types of the function parameters.

Test Plan

arc unit

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

This might have been partially motivated by some Facebook stuff at one point (they forked-but-not-really some pieces of XHPAST, see T635), but they've had something like ~2 years to clean things up and are still ~4 months behind HEAD.

This revision is now accepted and ready to land.Mar 4 2014, 7:02 PM

Closed by commit rARC0888b6616cbe (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

68 lines

Diff 19935

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Use PHP type hinting in `ArcanistXHPASTLinter`.ClosedPublicActions