Paths

Table of Contentst

Use PHP type hinting in `ArcanistXHPASTLinter`.
ClosedPublic
Actions

Authored by joshuaspence on Mar 3 2014, 11:36 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Feb 15, 9:41 AM

	Unknown Object (File)
	Sat, Feb 15, 9:41 AM

	Unknown Object (File)
	Sat, Feb 15, 9:41 AM

	Unknown Object (File)
	Sat, Feb 15, 9:41 AM

	Unknown Object (File)
	Sun, Feb 9, 11:43 AM

	Unknown Object (File)
	Sun, Feb 2, 1:12 PM

	Unknown Object (File)
	Sun, Jan 26, 5:10 PM

	Unknown Object (File)
	Sun, Jan 26, 5:10 PM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC0888b6616cbe: Use PHP type hinting in `ArcanistXHPASTLinter`.

Summary

Explicitly specify the types of the function parameters.

Test Plan

arc unit

Diff Detail

Repository

rARC Arcanist

Branch

xhpast_linter

Lint

Lint Passed

Unit

Test Failures

Event Timeline

This might have been partially motivated by some Facebook stuff at one point (they forked-but-not-really some pieces of XHPAST, see T635), but they've had something like ~2 years to clean things up and are still ~4 months behind HEAD.

This revision is now accepted and ready to land.Mar 4 2014, 7:02 PM

Closed by commit rARC0888b6616cbe (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

68 lines

Diff 19924

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Use PHP type hinting in `ArcanistXHPASTLinter`.ClosedPublicActions