Page MenuHomePhabricator

Simplified the logic in various functions.
ClosedPublic

Authored by joshuaspence on Mar 3 2014, 12:02 AM.
Tags
None
Referenced Files
F14036264: D8385.id19934.diff
Sun, Nov 10, 9:24 AM
F14036095: D8385.diff
Sun, Nov 10, 8:32 AM
F14035877: D8385.id19934.diff
Sun, Nov 10, 7:52 AM
F14035782: D8385.diff
Sun, Nov 10, 7:35 AM
F14035772: D8385.diff
Sun, Nov 10, 7:33 AM
F14021462: D8385.diff
Wed, Nov 6, 9:08 AM
F14002603: D8385.id19934.diff
Fri, Oct 25, 8:32 PM
F13972310: D8385.diff
Thu, Oct 17, 6:17 PM

Details

Summary
  • Tidied up ArcanistCSSLintLinter::getDefaultBinary.
  • Tidied up CSSLintLinter::getDefaultFlags function.
  • Tidied up ArcanistPhpcsLinter::getDefaultBinary function.
  • Tidied up ArcanistPEP8Linter::getDefaultFlags function
  • Tidied up ArcanistFlake8Linter::getDefaultFlags.
  • Tidied up ArcanistCppcheckLinter::getLintOptions.
  • Tidied up ArcanistCppcheckLinter::getLintPath.
  • Tidied up ArcanistCpplintLinter::getLintOptions.
  • Tidied up ArcanistCpplintLinter::getLintPath.
  • Removed child functions which are identical to the corresponding parent functions.
Test Plan

arc lint and arc unit.

Diff Detail

Repository
rARC Arcanist
Branch
simplify_logic
Lint
Lint Passed
Unit
Test Failures

Event Timeline

Skipping php54.lint-test, all unit tests pass.

epriestley edited edge metadata.

Great, thanks!

This revision is now accepted and ready to land.Mar 4 2014, 6:59 PM