Page MenuHomePhabricator

Simplified the logic in various functions.
ClosedPublic

Authored by joshuaspence on Mar 3 2014, 12:02 AM.
Tags
None
Referenced Files
F21205476: D8385.diff
Sun, Jul 5, 10:25 AM
F21204390: D8385.id19934.diff
Sun, Jul 5, 9:20 AM
Unknown Object (File)
Apr 19 2026, 5:17 AM
Unknown Object (File)
Mar 31 2026, 7:18 PM
Unknown Object (File)
Mar 8 2026, 4:32 AM
Unknown Object (File)
Mar 7 2026, 11:53 PM
Unknown Object (File)
Feb 16 2026, 6:05 PM
Unknown Object (File)
Dec 25 2025, 2:17 AM

Details

Summary
  • Tidied up ArcanistCSSLintLinter::getDefaultBinary.
  • Tidied up CSSLintLinter::getDefaultFlags function.
  • Tidied up ArcanistPhpcsLinter::getDefaultBinary function.
  • Tidied up ArcanistPEP8Linter::getDefaultFlags function
  • Tidied up ArcanistFlake8Linter::getDefaultFlags.
  • Tidied up ArcanistCppcheckLinter::getLintOptions.
  • Tidied up ArcanistCppcheckLinter::getLintPath.
  • Tidied up ArcanistCpplintLinter::getLintOptions.
  • Tidied up ArcanistCpplintLinter::getLintPath.
  • Removed child functions which are identical to the corresponding parent functions.
Test Plan

arc lint and arc unit.

Diff Detail

Repository
rARC Arcanist
Branch
simplify_logic
Lint
Lint Passed
Unit
Test Failures

Event Timeline

Skipping php54.lint-test, all unit tests pass.

epriestley edited edge metadata.

Great, thanks!

This revision is now accepted and ready to land.Mar 4 2014, 6:59 PM