Page MenuHomePhabricator

Simplified the logic in various functions.
ClosedPublic

Authored by joshuaspence on Mar 3 2014, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 15, 9:41 AM
Unknown Object (File)
Sat, Feb 15, 9:41 AM
Unknown Object (File)
Sat, Feb 15, 9:41 AM
Unknown Object (File)
Mon, Feb 10, 12:28 AM
Unknown Object (File)
Sun, Feb 2, 9:51 AM
Unknown Object (File)
Sun, Feb 2, 9:08 AM
Unknown Object (File)
Sun, Jan 26, 5:32 PM
Unknown Object (File)
Sun, Jan 26, 5:21 PM

Details

Summary
  • Tidied up ArcanistCSSLintLinter::getDefaultBinary.
  • Tidied up CSSLintLinter::getDefaultFlags function.
  • Tidied up ArcanistPhpcsLinter::getDefaultBinary function.
  • Tidied up ArcanistPEP8Linter::getDefaultFlags function
  • Tidied up ArcanistFlake8Linter::getDefaultFlags.
  • Tidied up ArcanistCppcheckLinter::getLintOptions.
  • Tidied up ArcanistCppcheckLinter::getLintPath.
  • Tidied up ArcanistCpplintLinter::getLintOptions.
  • Tidied up ArcanistCpplintLinter::getLintPath.
  • Removed child functions which are identical to the corresponding parent functions.
Test Plan

arc lint and arc unit.

Diff Detail

Repository
rARC Arcanist
Branch
simplify_logic
Lint
Lint Passed
Unit
Test Failures

Event Timeline

Skipping php54.lint-test, all unit tests pass.

epriestley edited edge metadata.

Great, thanks!

This revision is now accepted and ready to land.Mar 4 2014, 6:59 PM