Page MenuHomePhabricator

Use CustomField, not AuxiliaryField, to power RevisionView
ClosedPublic

Authored by epriestley on Feb 27 2014, 6:27 PM.
Tags
None
Referenced Files
F18245413: D8361.diff
Thu, Aug 21, 9:43 AM
F18082659: D8361.id19874.diff
Tue, Aug 5, 6:54 AM
F18082402: D8361.id19878.diff
Tue, Aug 5, 5:49 AM
F18082318: D8361.id19875.diff
Tue, Aug 5, 5:17 AM
F18069372: D8361.id.diff
Mon, Aug 4, 3:48 PM
F18050955: D8361.diff
Sun, Aug 3, 9:42 PM
F17868760: D8361.id19874.diff
Mon, Jul 28, 9:31 AM
F17868746: D8361.id19875.diff
Mon, Jul 28, 9:25 AM
Subscribers

Details

Summary

Ref T2222. This will probably have some rough edges for a bit (e.g., weird cases I didn't remember or think of), but there's no change to the underlying data and we can easily revert if things get too messy.

Test Plan

Looked at a variety of revisions and saw sensible output.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Feb 27 2014, 6:30 PM
  • Fix a spelling issue.
  • Remove an unused property.
conf/default.conf.php
790

As far as I know, only Facebook uses this. The modern event-based version has been available for something like 18 months.