Page MenuHomePhabricator

Use CustomField, not AuxiliaryField, to power RevisionView
ClosedPublic

Authored by epriestley on Feb 27 2014, 6:27 PM.
Tags
None
Referenced Files
F14010115: D8361.id19878.diff
Thu, Oct 31, 5:08 AM
F14006805: D8361.id19874.diff
Mon, Oct 28, 6:13 PM
F14005464: D8361.diff
Sun, Oct 27, 1:27 PM
F14004833: D8361.id.diff
Sun, Oct 27, 3:29 AM
F13996170: D8361.id19875.diff
Wed, Oct 23, 6:36 PM
F13991877: D8361.id19878.diff
Tue, Oct 22, 1:12 PM
F13991874: D8361.id19874.diff
Tue, Oct 22, 1:12 PM
F13991873: D8361.id19875.diff
Tue, Oct 22, 1:12 PM
Subscribers

Details

Summary

Ref T2222. This will probably have some rough edges for a bit (e.g., weird cases I didn't remember or think of), but there's no change to the underlying data and we can easily revert if things get too messy.

Test Plan

Looked at a variety of revisions and saw sensible output.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Feb 27 2014, 6:30 PM
  • Fix a spelling issue.
  • Remove an unused property.
conf/default.conf.php
790

As far as I know, only Facebook uses this. The modern event-based version has been available for something like 18 months.